Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set sci ns to mirror JVM ns #401

Merged
merged 5 commits into from
Feb 8, 2023
Merged

Set sci ns to mirror JVM ns #401

merged 5 commits into from
Feb 8, 2023

Conversation

mk
Copy link
Member

@mk mk commented Feb 3, 2023

Closes #362.

@mk
Copy link
Member Author

mk commented Feb 4, 2023

UI tests are green now but there's still issues e.g. with the slideshow viewer in the static build but that doesn't trigger a ui test failure because the render error doesn't log an error to the console atom.

As we can see in the commits to fix the ui tests, this is currently a breaking change. I'm thinking about keeping it this way though, because I think on the flip side, things are much clearer in the long term because there's no more question about what the v alias points to.

The breaking change has now happened in #410 (and the old aliases will probably still be revived before a release).

@mk
Copy link
Member Author

mk commented Feb 7, 2023

Need to follow up with good docs about this.

@mk mk merged commit 625b607 into main Feb 8, 2023
@mk mk deleted the set-sci-ns branch February 8, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evaluate sci forms in same namespace as notebook?
1 participant