Pass more Context to Viewer Functions + Cell Viewer #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zampino
force-pushed
the
context-viewers
branch
from
fd6973b to
9167295
Compare
zampino
changed the title
zampino
commented
Dec 13, 2023
notebooks/viewers/context.clj
Outdated
| (-> cell :result :nextjournal/value (as-> n (when (number? n) (even? n))))) | ||
| :show | ||
| %)))))) | ||
|
|
There was a problem hiding this comment.
@mk maybe an early feedback on this one 👆.
In some sense, controlling visibility is not "close to" the actual values which we want to display/hide. Unlike the usual customization of dedicated viewers matching different values, here we have just one spot in which to combine different predicates. Maybe good so anyway.
# Conflicts: # src/nextjournal/clerk/viewer.cljc
for ease of testing scenarios when we just can't wrap a value
this allows to easily hide anonymous toplevel forms, but still show examples
|
I checked that slideshow viewer still works, as this is the usual suspect when changing the shape of a presented notebook. Moreover #593 is not a regression from these changes, I'll fix that in a separate commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:wrappedkey, its value is called against the whole wrapped value instead of just the value