Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes for the phylogenetic workflow automation #19

Merged
merged 7 commits into from
Oct 7, 2024

Conversation

j23414
Copy link
Collaborator

@j23414 j23414 commented Oct 4, 2024

Description of proposed changes

This pull request addresses several issues that emerged after implementing automation for the ingest and phylogenetic workflows. The following improvements have been made:

  1. Renamed the final phylogenetic dataset from WNV-nextstrain_NA.json to WNV.json to align with the automation's expected format (<pathogen>.json or <pathogen>_*.json).
  2. Removed outdated output files from the phylogenetic/auspice/*.json directory to streamline the repository.
  3. To the phylogenetic workflow, added rules to download metadata and sequence files from s3 instead of pulling from the ingest/results directory
  4. Resolved an issue where uncompressed versions of metadata and sequence files were being uploaded due to the use of outdated scripts/upload-to-s3 scripts.
  5. Fixed the above bug by git subrepo-ing the vendored scripts and using the fixed vendored/upload-to-s3 script
  6. Delete any remaining unused or redundent scripts from the ingest/scripts folder

Related issue(s)

Checklist

  • Checks pass

@j23414 j23414 linked an issue Oct 4, 2024 that may be closed by this pull request
@j23414 j23414 merged commit 86740e3 into main Oct 7, 2024
4 checks passed
@j23414 j23414 deleted the 17-change-the-final-auspice-dataset-name branch October 7, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the final auspice dataset name
1 participant