ingest/automation: Update S3 URLs to uppercase #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automated uploads of files have been failing because of mismatch in casing. Update all S3 URLs to match expected uppercase since change in nextstrain/infra#31.
j23414
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Thank you!
I really do wonder if we should standardize on lowercase names to avoid this kind of error in the future...grr
|
Manually ran the ingest-to-phylogenetic workflow after merging. Ingest ran successfully and uploaded the new metadata TSV and sequences FASTA. However, the cache remained the same and did not trigger the phylo workflow...will investigate. |
joverlee521
added a commit
that referenced
this pull request
Oct 10, 2024
I noticed that even though files were update in ingest, the cache still didn't change and phylo did not run. Traced it back to incorrect S3 URLs leading to the use of the default hash in the cache. Output message to the GITHUB_STEP_SUMMARY so that we can immediately see if an S3 file doesn't have a sha256sum. <#22 (comment)>
joverlee521
added a commit
that referenced
this pull request
Oct 10, 2024
I noticed that even though files were update in ingest, the cache still didn't change and phylo did not run. Traced it back to incorrect S3 URLs leading to the use of the default hash in the cache. Output message to the GITHUB_STEP_SUMMARY so that we can immediately see if an S3 file doesn't have a sha256sum. <#22 (comment)>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Automated uploads of files have been failing because of mismatch in casing. Update all S3 URLs to match expected uppercase since change in nextstrain/infra#31.
Checklist