-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): allow xopen major version 2 #1532
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1532 +/- ##
==========================================
- Coverage 69.90% 69.89% -0.01%
==========================================
Files 75 75
Lines 7882 7887 +5
Branches 1933 1933
==========================================
+ Hits 5510 5513 +3
- Misses 2086 2088 +2
Partials 286 286 ☔ View full report in Codecov by Sentry. |
20d3aab
to
2a66cd3
Compare
See xopen changelog: https://github.com/pycompression/xopen/blob/main/README.rst#v200-2024-03-26 Maintain compatibility with v1 and v2, deprecate v1 with period of 4 months and requiring major version bump
4103bc8
to
6d5e438
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one more small thing
Co-authored-by: Victor Lin <13424970+victorlin@users.noreply.github.com>
I removed the whitespace ;) Would it be possible to release as 25.1.0? I know it's a bit silly given you released just recently - but it would mean we'd have full osx-arm64 conda support which would be rad :D |
@corneliusroemer for sure! Let me take a look at #1534 and I can release both at the same time. |
There were no breaking changes of relevance to us, so we can allow xopen v2.One small change: PipedCompressionReader/Writer was renamed to _pipedCompressionProgram.
If we want to support both v1 and v2, we have to do a bit of an ugly try/except import workaround. Probably worth keeping that for a few months because some programs people might want to use with augur potentially only support v1 at this point.
Once we merge and release this, we can install latest augur via conda-forge/bioconda natively on osx-arm64.
See xopen changelog: https://github.com/pycompression/xopen/blob/main/README.rst#v200-2024-03-26
Description of proposed changes
Related issue(s)
Checklist