Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type error in titer model cross-validation #1688

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

huddlej
Copy link
Contributor

@huddlej huddlej commented Nov 21, 2024

Description of proposed changes

Fixes type errors in titer model code that is only accessible through the developer's Python API but which prevented me from running cross-validation of titer models with that API. It looks like these were the only references to the dictionary methods of keys and values that didn't get updated in the past.

Related issue(s)

Checklist

  • Automated checks pass
  • Check if you need to add a changelog message
  • Check if you need to add tests
  • Check if you need to update docs

Fixes type errors in titer model code that is only accessible through
the developer's Python API but which prevented me from running
cross-validation of titer models with that API. It looks like these were
the only references to the dictionary methods of keys and values that
didn't get updated in the past.
@huddlej huddlej marked this pull request as draft November 21, 2024 19:48
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.30%. Comparing base (e90383b) to head (3a6df05).

Files with missing lines Patch % Lines
augur/titer_model.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1688   +/-   ##
=======================================
  Coverage   72.30%   72.30%           
=======================================
  Files          79       79           
  Lines        8276     8276           
  Branches     1691     1691           
=======================================
  Hits         5984     5984           
  Misses       2007     2007           
  Partials      285      285           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant