Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.8 support #1693

Merged
merged 4 commits into from
Dec 9, 2024
Merged

Drop Python 3.8 support #1693

merged 4 commits into from
Dec 9, 2024

Conversation

victorlin
Copy link
Member

@victorlin victorlin commented Dec 5, 2024

Description of proposed changes

Python 3.8 reached EOL ~2 months ago. Many dependencies have already dropped support in recent versions.

Use 3.9 as the minimum Python version.

Related issue(s)

Closes #1680

Checklist

  • Automated checks pass
  • Check if you need to add a changelog message
  • Check if you need to add tests
  • Check if you need to update docs

@victorlin victorlin added the breaking Makes a backwards incompatible change and should wait for major release label Dec 5, 2024
@victorlin victorlin self-assigned this Dec 5, 2024
Python 3.8 reached EOL ~2 months ago¹. Many dependencies have already
dropped support in recent versions.

Use 3.9 as the minimum Python version.

¹ https://devguide.python.org/versions/
This is now consistently the default with Python 3.9 onwards.¹

¹ <https://docs.python.org/3.9/whatsnew/3.9.html#sys>
It's not clear to me how to use the dictionary union operator to
implement deep merge (a non-trivial problem¹).

¹ https://stackoverflow.com/q/7204805
@victorlin victorlin force-pushed the victorlin/drop-py38 branch from 6324827 to d85578c Compare December 9, 2024 18:11
@victorlin victorlin marked this pull request as ready for review December 9, 2024 18:11
@victorlin victorlin merged commit e0adcd1 into master Dec 9, 2024
27 of 28 checks passed
@victorlin victorlin deleted the victorlin/drop-py38 branch December 9, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Makes a backwards incompatible change and should wait for major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Python 3.8 support
2 participants