Revert broken newick parsing #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nextstrain-bot
temporarily deployed
to
auspice-us-revert-broke-rsv0nm
|
Failure is due to |
victorlin
approved these changes
Dec 6, 2023
Two recent issues (#71, #72) provide examples where the improved parsing either didn't parse a valid newick tree or (much more worryingly) returned an entirely incorrect tree structure, including nodes not present in the newick. See those issues for details, including the tree files. While this reversion will re-introduce bugs such as #66 and the bug in <https://discussion.nextstrain.org/t/displaying-trees-from-ncbi-pathogen-browser-in-auspice-us/1456/4>, but they are lesser than the bugs introduced by #69. This reverts commit cabba98, although subsequent changes to package-lock.json mean it's not a clean revert.
The newick parser we use is known to have issues with quoted node names, as it will parse the node name content as newick. As a quick fix, disallow trees with quotes. The result is that the trees in #66 and <https://discussion.nextstrain.org/t/displaying-trees-from-ncbi-pathogen-browser-in-auspice-us/1456/4> will now result in an error. The downside is trees with quoted names but no newick-like structure within the node name will also fail to load.
jameshadfield
force-pushed
the
revert-broken-newick-parsing
branch
from
f7d4b5e to
2413e3c
Compare
nextstrain-bot
temporarily deployed
to
auspice-us-revert-broke-6hjsbg
This was referenced Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages for details.
This reversion is not to say we shouldn't improve our newick parsing - we should! - but that improvements need to be well tested.