Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Grid" and "Full" icons are not click targets, only the text responds to clicks #1911

Closed
genehack opened this issue Nov 19, 2024 · 0 comments · Fixed by #1912
Closed

"Grid" and "Full" icons are not click targets, only the text responds to clicks #1911

genehack opened this issue Nov 19, 2024 · 0 comments · Fixed by #1912
Assignees
@genehack
Labels
bug Something isn't working

Comments

@genehack
Copy link
Contributor

Current Behavior

In the Auspice sidebar, in the "Display" section, clicking on the icons to the left of "FULL" or "GRID" does not do anything.

Screenshot 2024-11-19 at 14 52 46

Specifically, in the screenshot, clicking the blue circles loads the expected layout; clicking the red hexes does nothing.

Expected behavior

Clicking the icons should do the same thing as clicking the word.

How to reproduce

Steps to reproduce the current behavior:

  1. Visualize a tree
  2. Click the icon next to "Grid"
  3. See that nothing happens, get increasingly frustrated
  4. Click the text "Grid", see the layout change, think, "boy that's poor a11y isn't it"
@genehack genehack added the bug Something isn't working label Nov 19, 2024
genehack added a commit that referenced this issue Nov 20, 2024
@genehack
Make icons change layout too [#1911]
314c3e7
genehack added a commit that referenced this issue Nov 20, 2024
@genehack
Make icons change layout too [#1911]
d4688c0
@genehack genehack mentioned this issue Nov 20, 2024
Merged
3 tasks
@genehack genehack self-assigned this Nov 20, 2024
genehack added a commit that referenced this issue Dec 5, 2024
@genehack
Make icons change layout too [#1911]
400d5ee
genehack added a commit that referenced this issue Dec 6, 2024
@genehack
Make icons change layout too [#1911]
6c2bfd6 
This leads to a slight styling change, but is probably Close Enough™
genehack added a commit that referenced this issue Dec 6, 2024
@genehack
Make icons change layout too [#1911]
7971a1e 
This leads to a slight styling change, but is probably Close Enough™
genehack added a commit that referenced this issue Dec 6, 2024
@genehack
Make icons change layout too [#1911]
261b86a 
This leads to a slight styling change, but is probably Close Enough™
genehack added a commit that referenced this issue Dec 6, 2024
@genehack
Merge pull request #1912 from nextstrain/make-grid-full-icons-work-1911
0fea602 
Make icons change layout too [#1911]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@genehack genehack

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make icons change layout too [#1911] nextstrain/auspice
1 participant
@genehack