Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable preview PRs for auspice.us #1567

Merged
merged 5 commits into from
Oct 10, 2022
Merged

Conversation

victorlin
Copy link
Member

@victorlin victorlin commented Oct 10, 2022

Description of proposed changes

Currently, preview PRs are only created on the nextstrain.org repo. Also create them for auspice.us and add inputs to select which PRs to make. This looks like:

workflow-dispatch-ui

Related issue(s)

N/A

Testing

  • Checks pass
  • Manually triggered run is successful
  • Generated PRs look good

This removes the nextstrain.org-specific logic and changes the workflow
trigger to be workflow_call with a repository name input.
@victorlin victorlin self-assigned this Oct 10, 2022
@nextstrain-bot nextstrain-bot temporarily deployed to auspice-victorlin-auspi-1mysom October 10, 2022 21:16 Inactive
@nextstrain-bot nextstrain-bot temporarily deployed to auspice-victorlin-auspi-1mysom October 10, 2022 21:19 Inactive
@nextstrain-bot nextstrain-bot temporarily deployed to auspice-victorlin-auspi-1mysom October 10, 2022 21:19 Inactive
@nextstrain-bot nextstrain-bot temporarily deployed to auspice-victorlin-auspi-1mysom October 10, 2022 21:20 Inactive
@nextstrain-bot nextstrain-bot temporarily deployed to auspice-victorlin-auspi-1mysom October 10, 2022 21:21 Inactive
@nextstrain-bot nextstrain-bot temporarily deployed to auspice-victorlin-auspi-1mysom October 10, 2022 21:22 Inactive
This should restore existing functionality to generate a preview PR on
the nextstrain.org repo.
@victorlin victorlin force-pushed the victorlin/auspice-us-preview-prs branch from c9579b7 to c6d14b6 Compare October 10, 2022 21:46
@nextstrain-bot nextstrain-bot temporarily deployed to auspice-victorlin-auspi-1mysom October 10, 2022 21:46 Inactive
@victorlin victorlin marked this pull request as ready for review October 10, 2022 22:21
@victorlin victorlin marked this pull request as draft October 10, 2022 22:22
Since it is manually triggered now, might as well allow the user to
specify which repos to make PRs in. Default is no selection (opt-in).
@nextstrain-bot nextstrain-bot temporarily deployed to auspice-victorlin-auspi-1mysom October 10, 2022 22:43 Inactive
@victorlin victorlin marked this pull request as ready for review October 10, 2022 22:45
@victorlin victorlin requested a review from a team October 10, 2022 22:45
@jameshadfield
Copy link
Member

Awesome! This is a great idea & the code looks good.

GitHub actions do constantly confuse me... I think I've tested this by dispatching this action from this PR's branch (which I'm sure used the updated action definition, as the repo-checkboxes came up when I selected this branch and they're implemented here for the first time). I'll approve this PR when the action finishes (it's running into the npm install slowness I think).

@victorlin
Copy link
Member Author

@jameshadfield yes, that looks right! It'll use the workflow file from the branch that's selected for run.

npm install slowness indeed... and I noticed that it's not just here in the "make PRs" workflow, but also in the downstream PR checks (note how long npm ci took to run on nextstrain/nextstrain.org#608).

Copy link
Member

@jameshadfield jameshadfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this merged!

@victorlin victorlin merged commit 2c7eb8d into master Oct 10, 2022
@victorlin victorlin deleted the victorlin/auspice-us-preview-prs branch October 10, 2022 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants