Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make_pr_for_downstream_repo: Use Node.js 16 #1662

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

victorlin
Copy link
Member

@victorlin victorlin commented Apr 7, 2023

Reasons to bump:

  1. Both downstream repos use Node.js 16 now.
  2. NPM 6 (bundled with Node.js 14) is slow to install Auspice from a GitHub commit reference. Later versions of NPM should fix this¹.

¹ npm/cli#4896

Related issues

Addresses concern raised in #1661 (comment).

Testing

  • Checks pass
  • (to be done by a Nextstrain team member) Create preview PRs on downstream repositories (run)
  • Check results of the run linked above.
    • The step to install Auspice from a GitHub commit reference now runs in ~10m opposed to ~15m. Still not the best, but better than before.

Reasons to bump:

1. Both downstream repos use Node.js 16 now.
2. NPM 6 (bundled with Node.js 14) is slow to install Auspice from a
   GitHub commit reference. Later versions of NPM should fix this¹.

¹ npm/cli#4896
@victorlin victorlin merged commit 174dc52 into master Apr 10, 2023
@victorlin victorlin deleted the victorlin/update-preview-pr-workflow-node-version branch April 10, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

3 participants