Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix measurements bugs #1802

Merged
merged 5 commits into from
Jul 30, 2024
Merged

Fix measurements bugs #1802

merged 5 commits into from
Jul 30, 2024

Conversation

joverlee521
Copy link
Contributor

@joverlee521 joverlee521 commented Jul 29, 2024 •
edited
Loading

Description of proposed changes

Small fixes for bugs in the measurements panel.

Resolves #1757
Resolves #1758

Checklist

@joverlee521
docs: fix link to dev docs
8a421f6
@joverlee521
measurements: Allow thresholds to be undefined
eaef12f 
Prevent the app from crashing if the collection's threshold is
undefined.

Resolves <#1757>
@joverlee521
measurements: Fix measurements_display typo
4d69f60 
Honor the collection's `display_defaults.measurements_display` that is
provided in the measurements JSON.

Resolves <#1758>
@nextstrain-bot nextstrain-bot temporarily deployed to auspice-measurements-bu-gvbkji July 29, 2024 23:55 Inactive
@joverlee521 joverlee521 temporarily deployed to auspice-measurements-bu-gvbkji July 30, 2024 00:03 Inactive
@nextstrain-bot nextstrain-bot mentioned this pull request Jul 30, 2024
Closed
genehack
genehack approved these changes Jul 30, 2024
View reviewed changes
src/components/measurements/measurementsD3.js Outdated Show resolved Hide resolved
@joverlee521 joverlee521 temporarily deployed to auspice-measurements-bu-gvbkji July 30, 2024 19:52 Inactive
@joverlee521
Copy link
Contributor Author

Thank you @huddlej for the detailed steps to reproduce bug in #1758 and #1757.

I was able to verify both issues are fixed in the downstream auspice.us test app.

@joverlee521 joverlee521 merged commit 6955728 into master Jul 30, 2024
26 checks passed
@joverlee521 joverlee521 deleted the measurements-bugs branch July 30, 2024 20:27
@huddlej
Copy link
Contributor

huddlej commented Jul 30, 2024

Awesome! Thank you, @joverlee521!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@genehack genehack genehack approved these changes

Assignees
No one assigned
Labels
preview on auspice.us
Projects
None yet
Milestone
No milestone
4 participants
@joverlee521 @huddlej @genehack @nextstrain-bot