Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI fails due to change in Python 3.6 deprecation warning from cryptography #245

Closed
tsibley opened this issue Jan 3, 2023 · 1 comment · Fixed by #246
Closed

CI fails due to change in Python 3.6 deprecation warning from cryptography #245

tsibley opened this issue Jan 3, 2023 · 1 comment · Fixed by #246
Assignees
Labels
bug Something isn't working

Comments

@tsibley
Copy link
Member

tsibley commented Jan 3, 2023

CI is failing (example) on test-source on 3.6 because of a Python 3.6 deprecation warning from cryptography:

E   cryptography.utils.CryptographyDeprecationWarning: Python 3.6 is no longer supported by the Python core team. Therefore, support for it is deprecated in cryptography. The next release of cryptography (40.0) will be the last to support Python 3.6.

We've been catching this since cryptography 37 and 3977fee with:

# Ignore noisy warning from cryptography 37.0.0 about deprecated support for Python 3.6.
with warnings.catch_warnings():
warnings.filterwarnings(
"ignore",
message = "Python 3\\.6 is no longer supported by the Python core team\\. Therefore, support for it is deprecated in cryptography and will be removed in a future release\\.",
category = UserWarning)
import jwt
import jwt.exceptions

but cryptography 39 just released on 1 Jan changed the warning message so we now fail to silence it.

@tsibley tsibley added the bug Something isn't working label Jan 3, 2023
@tsibley
Copy link
Member Author

tsibley commented Jan 3, 2023

Annoyingly, I noticed this when attempting to release 6.0.1 with changes I prepped for release 2 weeks ago (before I got the flu and before the holidays). So I'll need to fix it and release 6.0.1.post1 or something silly. This is a slightly annoying property of the order of operations of the release process. In some ways it'd be nicer to say, "ok, designate this successful CI build as release X.Y.Z" rather than "consider this source code X.Y.Z and run the CI release process; hopefully it doesn't fail!".

@tsibley tsibley self-assigned this Jan 3, 2023
tsibley added a commit that referenced this issue Jan 3, 2023
… support

Version 39 changed the wording of the deprecation warning added by
version 37.  39 still works on Python 3.6 but now warns that version 40
will be the last to include support.  Without supression, the
deprecation causes loud, user-visible warnings when running any command:

    Python 3.6 is no longer supported by the Python core team. Therefore,
    support for it is deprecated in cryptography. The next release of
    cryptography (40.0) will be the last to support Python 3.6.

This is more reason to drop 3.6 ourselves eventually as we'll not want
to be using an older and older cryptography release.  In the meantime,
however, squash the warning since it does no good for end users.

Resolves <#245>.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant