runner.docker: Set docker.image setting to the latest build-* tag by default #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instead of the "legacy" ConfigParser.set() API. They're functionally equivalent, but I noticed other places in this module use the mapping protocol (e.g. del config[section]) where possible, so keep our usage consistent.
Using a get() + conditional set() isn't appropriate as they're separately locked and require reading the config file twice (and thus can be inconsistent/corrupting). In practice it's likely to be fine given our spare usage, but the mapping protocol's .setdefault() is right there so might as well use it.
Under --set-default, check-setup sets core.runner, and now the default runner itself has a chance to set additional default config.
…default This is called when the runner is set as the default runner by `nextstrain check-setup --set-default`. Partially resolves <#167>.
|
It's not, but I can't unlink it because of the reference in the commit message. (Well, I could rewrite the commit message, but meh, it's clear to humans.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is called when the runner is set as the default runner by
nextstrain check-setup --set-default.Partially resolves #167.
See other commit messages for more details.
Testing
Tested new setting of defaults locally.
pytestpasses locally.