standalone-installer-windows: Use call operator (&) instead of Invoke-Expression #277
Conversation
victorlin
changed the title
There was a problem hiding this comment.
Ah, yes, this is much better. I vaguely knew about PowerShell's call operator, but didn't really grok the subtlety until now.
Totally minor, but in the commit message, I'd probably link to the official docs—https://learn.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_operators?view=powershell-7.3#call-operator-—instead of a third-party site.
CI is failing due to #274.
It is not uncommon for user home directories to have spaces, and Invoke-Expression does not work well with paths that have spaces¹. The call operator is more suitable for this use case. Quoting updated to reflect call operator² syntax³. ¹ https://devblogs.microsoft.com/powershell/invoke-expression-considered-harmful/ ² https://learn.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_operators?view=powershell-7.3#call-operator- ³ https://ss64.com/ps/call.html
victorlin
force-pushed
the
victorlin/fix-windows-install
branch
from
4066a63 to
6f89bf4
Compare
Fair point. Updated with both links, since the official docs don't provide the syntax reference. |
|
CI / test-source is failing but on |
Description of proposed changes
It is not uncommon for user home directories to have spaces, and Invoke-Expression does not work well with paths that have spaces. The call operator is more suitable for this use case.
Quoting updated to reflect call operator syntax.
Related issue(s)
Fixes #276
Testing
C:\Users\test user\.Checks passsome are failing because of unrelated reasons, but this change should not affect the outcome of those checks