Fix Pyright errors #281
Merged
Fix Pyright errors #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix Pyright errors that have been raised in our scheduled CI runs since the release of Pyright 1.1.306.¹ I have not dug into the Pyright changelog to determine the exact change that leads to this new error. ¹ https://github.com/nextstrain/cli/actions/runs/4874920417
joverlee521
commented
May 16, 2023
| @@ -65,6 +65,7 @@ def upload_workdir(workdir: Path, bucket: S3Bucket, run_id: str) -> S3Object: | |||
| ]) | |||
|
|
|||
| # Stream writes directly to the remote ZIP file | |||
| remote_file: Any | |||
There was a problem hiding this comment.
In the future, we may consider creating type stubs for fsspec so that we can provide the correct type instead of Any.
|
Merging since this is a small type fix that will only affect the Pyright test. The checks that are currently failing are the ones related to #274 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Fix Pyright errors that have been raised in our scheduled CI runs since the release of Pyright 1.1.306.¹ I have not dug into the Pyright changelog to determine the exact change that leads to this new error.
¹ https://github.com/nextstrain/cli/actions/runs/4874920417
Testing