remote download: Names with dots #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into a separate function so that I can add doctests to it.
Demonstrate and validate our basic expectations. In the next commit, I'll add a failing test for a bug.
…destination bug
The root of the problem is the same: dots are not being handled
properly. They're assumed to always indicate an extension, but we can
and should support non-extension dots.
Fails with:
Expected:
['mpox.clade-IIb.json',
'mpox.clade-IIb_root-sequence.json',
'mpox.clade-IIb_tip-frequencies.json',
'mpox.clade-IIb_measurements.json']
Got:
['mpox.json', 'mpox_root-sequence.json', 'mpox_tip-frequencies.json', 'mpox_measurements.json']
and
Expected:
['2022.04.29-ncov_omicron-BA-two.json',
'2022.04.29-ncov_omicron-BA-two_root-sequence.json',
'2022.04.29-ncov_omicron-BA-two_tip-frequencies.json',
'2022.04.29-ncov_omicron-BA-two_measurements.json']
Got:
['2022.04.json', '2022.json', '2022.json', '2022.json']
The latter failure reproduces a user report of issues downloading. The
former was a closely-related failure case I noticed while debugging the
latter.
Related-to: <#380>
Avoids careless Path.with_suffix() usage. Resolves: <#380>
…ar suffix handling
Mixed subresource extensions work due to the previous bug fix in
"remote.nextstrain_dot_org: Fix download dots-in-destination bug"
(5d9533f) but empty sidecar suffixes on non-primary subresources do not.
I noted this edge case when working on other fixes in this code. We
don't currently run into this edge case, but it's good to consider and
prevent anyway to avoid future surprises if we ever do. Our data model
makes it possible and it's not an unreasonable use case.
The first test fails with:
Expected:
['baz.md', 'baz.json', 'baz_root-sequence.json']
Got:
['baz.md', 'baz_.json', 'baz_root-sequence.json']
and the subsequent similar tests fail similarly.
…ling Don't assume that all non-primary subresources will have sidecar suffixes.
genehack
approved these changes
Jul 23, 2024
joverlee521
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages.
Resolves #380.
Checklist