runner.aws_batch: Gracefully handle errors when fetching logs for completed jobs #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pleted jobs For completed jobs, it's more useful to continue on with printing the job status (e.g. success or reason for failure) and downloading job results even if an error occurs when fetching logs. As a concrete example, we've observed cases where a failed job has a log stream associated with it in Batch but that log stream does not actually exist in CloudWatch Logs.¹ The log fetch error hid the reason for job failure, hampering troubleshooting. ¹ <https://bedfordlab.slack.com/archives/C01LCTT7JNN/p1730406138009409>
jameshadfield
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Much improved for the error I ran into.
Before:
Attaching to Nextstrain AWS Batch Job ID: XXX
Job is FAILED
Traceback (most recent call last):
...
botocore.errorfactory.ResourceNotFoundException: An error occurred (ResourceNotFoundException) when calling the FilterLogEvents operation: The specified log stream does not exist.After:
Attaching to Nextstrain AWS Batch Job ID: XXX
Job is FAILED
Unable to fetch job logs: An error occurred (ResourceNotFoundException) when calling the FilterLogEvents operation: The specified log stream does not exist.
Job FAILED after 4.1 minutes (DockerTimeoutError: Could not transition to created; timed out after waiting 4m0s, Task failed to start)
joverlee521
approved these changes
Oct 31, 2024
genehack
approved these changes
Nov 1, 2024
|
This is part of the 8.5.4 release that I've just kicked off. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For completed jobs, it's more useful to continue on with printing the job status (e.g. success or reason for failure) and downloading job results even if an error occurs when fetching logs. As a concrete example, we've observed cases where a failed job has a log stream associated with it in Batch but that log stream does not actually exist in CloudWatch Logs.¹ The log fetch error hid the reason for job failure, hampering troubleshooting.
¹ https://bedfordlab.slack.com/archives/C01LCTT7JNN/p1730406138009409
Checklist