Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default clade color #73

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Add default clade color #73

merged 2 commits into from
Nov 28, 2023

Conversation

joverlee521
Copy link
Contributor

@joverlee521 joverlee521 commented Nov 28, 2023

Description of proposed changes

Remove the assertion that has been blocking the pipeline due to lack
of clade definition for 21L/BA.2.86.¹

Adds a default dark grey color for clades that lack clade definition so
that we can see them on the forecasts site. In the future, we may want
to add a custom Slack notification fo these clades so that we get a
louder internal notification.

¹ https://bedfordlab.slack.com/archives/C036L7V615F/p1701195514961829

Related issue(s)

Previous conversation for context

Checklist

Remove the assertion that has been blocking the pipeline due to lack
of clade definition for 21L/BA.2.86.¹

Adds a default dark grey color for clades that lack clade definition so
that we can see them on the forecasts site. In the future, we may want
to add a custom Slack notification fo these clades so that we get a
louder internal notification.

¹ https://bedfordlab.slack.com/archives/C036L7V615F/p1701195514961829
@joverlee521
Copy link
Contributor Author

The 21L clade definitely sticks out in the viz from the trial run:

Screenshot 2023-11-28 at 1 49 01 PM
Screenshot 2023-11-28 at 1 49 11 PM

@joverlee521 joverlee521 merged commit 3309869 into main Nov 28, 2023
4 checks passed
@joverlee521 joverlee521 deleted the default-clade-color branch November 28, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants