fix(cli): correctly deprecate input args #1271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ivan-aksamentov
force-pushed
the
fix/cli-args-deprecate-corr
branch
from
46d8654 to
faa9090
Compare
- Add error message for removed `--input-virus-properties`, `--input-root-seq`, `--reference`, `--input-gene-map`, `--genemap` - Deduplicate error messages text. - Group deprecated args in one place
ivan-aksamentov
force-pushed
the
fix/cli-args-deprecate-corr
branch
from
faa9090 to
847eaa1
Compare
Emit messages when the following args are used: For `dataset get`: ``` --reference --attributes ``` For `dataset list`: ``` --reference --attributes --include-old ``` Reminder, Nextclade v3 datasets are uniquely identified by their name (path) and tag only, so all other attributes lost their meaning. All version tags are listed so `--include-old` is no longer relevant.
ivan-aksamentov
force-pushed
the
fix/cli-args-deprecate-corr
branch
from
cc13040 to
94c6ee7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--input-virus-properties,--input-root-seq,--reference,--input-gene-map,--genemap