Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve type narrowing and error handling #1073

Merged
merged 10 commits into from
Nov 19, 2024
Prev Previous commit
Next Next commit
Update Group prop types
This better reflects the actual usage.
victorlin committed Nov 19, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 9fab60dac4966d26ca23892ae71fb0517ae5e118
4 changes: 2 additions & 2 deletions static-site/src/components/ListResources/types.ts
Original file line number Diff line number Diff line change
@@ -10,8 +10,8 @@ export type SortMethod = "lastUpdated" | "alphabetical";
export interface Group {
groupName: string
nResources: number
nVersions?: number
lastUpdated: string // date
nVersions: number | undefined
lastUpdated: string | undefined
resources: Resource[]
groupUrl?: string
groupDisplayName?: string
2 changes: 1 addition & 1 deletion static-site/src/components/ListResources/useDataFetch.ts
Original file line number Diff line number Diff line change
@@ -106,7 +106,7 @@ function groupsFrom(
groupName: groupName,
nResources: resources.length,
nVersions: resources.reduce((total, r) => r.nVersions ? total+r.nVersions : total, 0) || undefined,
lastUpdated: resources.map((r) => r.lastUpdated).sort().at(-1)!,
lastUpdated: resources.map((r) => r.lastUpdated).sort().at(-1),
resources,
}
/* add optional properties */