Lint everything

.eslintrc.yaml

@@ -14,10 +14,10 @@ ignorePatterns:
   - auspice-client/
   - docs/
   - node_modules/
-  - static-site/
 
 rules:
   # Code quality rules
+  eqeqeq: error
   no-unused-vars: error
   no-use-before-define: ["error", { "functions": false, "classes": false }]
   prefer-const: ["error", {"destructuring": "all"}]

.github/workflows/ci.yml

@@ -37,8 +37,7 @@ jobs:
           node-version-file: 'package.json'
       - run: node --version
       - run: npm ci
-      - run: npm run lint:server
-      - run: npm run lint:static-site
+      - run: npm run lint
       - run: node ./scripts/check-resource-index-match.js
 
   # Build into Heroku slug so we can deploy the same build that we test.

package.json

@@ -14,8 +14,8 @@
   "scripts": {
     "build": "./build.sh",
     "build:feeds": "node scripts/generate-blog-feeds.js",
-    "lint": "npm run lint:server",
-    "lint:server": "DEBUG=eslint:cli-engine npx eslint --max-warnings=0 --ext .js,.jsx .",
+    "lint": "DEBUG=eslint:cli-engine npx eslint --max-warnings=0 --ext .js,.jsx,.ts,.tsx .",
+    "lint:server": "DEBUG=eslint:cli-engine npx eslint --max-warnings=0 --ext .js,.jsx --ignore-pattern static-site .",
     "lint:static-site": "cd static-site && DEBUG=eslint:cli-engine npx eslint --max-warnings=0 --ext .js,.jsx,.ts,.tsx .",
     "server": "node server.js",
     "groups": "node server.js --app ./src/groupsApp.js",

src/authz/index.js

@@ -18,9 +18,9 @@ import tags from './tags.js';
  */
 function authorized(user, action, object) {
   // user may be null
-  assert(!user || user.authzRoles != null, "user.authzRoles is not null if user is not null");
+  assert(!user || user.authzRoles !== null, "user.authzRoles is not null if user is not null");
   assert(actions.has(action), "action is known");
-  assert(object != null, "object is not null");
+  assert(object !== null, "object is not null");
 
   /* As a safe guard, anonymous users can only ever read, regardless of
    * policies right now.  We don't have any use cases right now where letting

src/sources/groups.js

@@ -112,7 +112,7 @@ class GroupSource extends Source {
     let {title, byline, website, showDatasets, showNarratives} = frontMatter;
 
     // Must be an allowed protocol
-    if (website != null) {
+    if (website !== null) {
       const {protocol} = parseUrl(website) ?? {};
       const allowedProtocols = new Set(["https:", "http:", "ftp:", "ftps:", "mailto:"]);
       if (!allowedProtocols.has(protocol)) {

src/upstream.js

@@ -346,7 +346,7 @@ function copyHeaders(headerSource, headerNames) {
   return Object.fromEntries(
     headerNames
       .map(name => [name, headerSource.get(name)])
-      .filter(([name, value]) => value != null && value !== "") // eslint-disable-line no-unused-vars
+      .filter(([name, value]) => value !== null && value !== "") // eslint-disable-line no-unused-vars
   );
 }
 

src/utils/index.js

@@ -109,7 +109,7 @@ const parseNarrativeLanguage = (narrative) => {
 const normalizeHeaders = (headers) => {
   const withValues =
     Object.entries(headers)
-      .filter(([, value]) => value != null && value !== "");
+      .filter(([, value]) => value !== null && value !== "");
 
   /* Use the WHATWG Headers object to do most of the normalization, including
    * lowercasing and combining duplicate headers as appropriate.

src/utils/scripts.js

@@ -91,7 +91,7 @@ async function run(argv) {
     proc.stderr.on("data", data => console.error(data.toString().replace(/\n$/, "")));
 
     proc.on("close", (code, signal) => {
-      const result = code !== 0 || signal != null
+      const result = code !== 0 || signal !== null
         ? reject
         : resolve;
       return result({code, signal, argv});

static-site/.eslintrc.yaml

@@ -1,6 +1,3 @@
-# Prevent parent configuration from being applied.
-root: true
-
 plugins:
   - "@typescript-eslint"
 
@@ -27,6 +24,11 @@ ignorePatterns:
   - public/
 
 rules:
+  # The TypeScript compiler is able to handle usage of type definitions before
+  # they are defined.
+  no-use-before-define: off
+  "@typescript-eslint/no-use-before-define": ["error", { "functions": false, "classes": false, "typedefs": false }]
+
   react/prop-types: off # Remove this override once all props have been typed using PropTypes or TypeScript.
   '@next/next/no-img-element': off # Remove this if we use next.js optimisations for <img>
   '@next/next/no-html-link-for-pages': off
@@ -38,6 +40,16 @@ overrides:
     rules:
       '@typescript-eslint/no-var-requires': off
 
+  # React components can use variables before they are defined.
+  # This isn't great, as jsx/tsx doesn't imply React usage, but it avoids
+  # unnecessary workarounds such as:
+  # https://github.com/nextstrain/auspice/commit/af4c742f3855fa90ea292b4882293ebc66ace853
+  - files:
+      - '**.[jt]sx'
+    rules:
+      no-use-before-define: off
+      "@typescript-eslint/no-use-before-define": ["error", { "functions": false, "classes": false, "variables": false }]
+
 parserOptions:
   sourceType: module
   ecmaVersion: 2022

static-site/src/components/ExpandableTiles/index.tsx

@@ -31,7 +31,7 @@ export const ExpandableTiles = <AnyTile extends Tile>({tiles, tileWidth, tileHei
   function tilesContainerRef(tilesContainer: HTMLDivElement) {
     if (!tilesContainer) return;
 
-    if(tilesContainerHeight != tilesContainer.clientHeight) {
+    if(tilesContainerHeight !== tilesContainer.clientHeight) {
       setTilesContainerHeight(tilesContainer.clientHeight)
     }
   }

static-site/src/components/ListResources/IndividualResource.tsx

@@ -130,7 +130,7 @@
     // don't do anything if the ref is undefined or the parent is not a div (IndividualResourceContainer)
     if (!ref.current
      || !ref.current.parentNode
-     || ref.current.parentNode.nodeName != 'DIV') return;
+     || ref.current.parentNode.nodeName !== 'DIV') return;
 
     /* The column CSS is great but doesn't allow us to know if an element is at
     the top of its column, so we resort to JS */
@@ -153,8 +153,8 @@
           Icon={MdHistory}
           text={`${resource.updateCadence.summary} (n=${resource.nVersions})`}
           handleClick={() => setModalResource(resource)}
         />
       </TooltipWrapper>
     )
   }
 

static-site/src/components/nav-bar/index.tsx

@@ -119,7 +119,7 @@ const NavBar = ({ minified }: {
 
   return (
     <NavContainer>
-      {Router.pathname != "/" && <>
+      {Router.pathname !== "/" && <>
         <Logo />
         <LogoType />
       </>}