fix: travis error during installation of dependencies #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j23414
changed the title
victorlin
requested changes
Mar 14, 2022
| # Install nextstrain cli | ||
| - conda install -n base -c conda-forge mamba --yes | ||
| - conda activate base | ||
| - mamba create -n nextstrain -c bioconda nextstrain-cli --yes |
There was a problem hiding this comment.
This would install the latest nextstrain-cli from bioconda rather than latest from the default branch (current behavior with pip3 install git+https://github.com/nextstrain/cli). I think this should be fine though.
Co-authored-by: Victor Lin <13424970+victorlin@users.noreply.github.com>
Co-authored-by: Victor Lin <13424970+victorlin@users.noreply.github.com>
victorlin
approved these changes
Mar 14, 2022
tsibley
added a commit
that referenced
this pull request
Apr 1, 2022
We've been slowly moving everything off Travis CI in favor of centralizing on GitHub. More acutely motivated here by some Travis-specific errors, previously worked around by <#14>. Reverts back to a simple pip install instead of conda/mamba setup as much of it was unnecessary. See discussion in <nextstrain/measles#3 (comment)>.
tsibley
added a commit
that referenced
this pull request
Apr 1, 2022
We've been slowly moving everything off Travis CI in favor of centralizing on GitHub. More acutely motivated here by some Travis-specific errors, previously worked around by <#14>. Reverts back to a simple pip install instead of conda/mamba setup as much of it was unnecessary. See discussion in <nextstrain/measles#3 (comment)>.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Switching from
pip3 installtomamba installfixed this travis ci error.The
pip3 installwas nice as a very concise one-liner. Themamba installis more consistent with our nextstrain install docs. Feel free to suggest a cleaner fix. Another alternative solution is to set up CI using github actions.Testing
See alt_travis travis.ci passing build.