fix(theme): make select styles consistent with input

[macci001]

Closes #3876

📝 Description

The changes in this PR makes the select and input styles consistent.

⛳️ Current behaviour (updates)

Screen.Recording.2024-10-13.at.2.52.49.PM.mov

🚀 New behaviour

• Flat Variant
  • Changes are made to make the hover color consistent

Screen.Recording.2024-11-06.at.2.09.30.AM.mov

Screen.Recording.2024-11-06.at.2.11.22.AM.mov

• Faded
  • Removing the bg-color change on hover
  • BorderColor added in case of focus and popover-open

Screen.Recording.2024-10-13.at.4.48.05.PM.mov

• Bordered
  • No styling change, just formatting change to remove the repeated style
• Underlined
  • No changes.

💣 Is this a breaking change (Yes/No): No

Summary by CodeRabbit

• New Features
  • Updated versioning for multiple @nextui-org packages, indicating potential new features and improvements.
• Style
  • Enhanced visual feedback for input and select components with updated hover and focus states.
  • Adjusted background and border colors for various input and select variants to improve user interaction.
• Documentation
  • Exported new types and variables for input and select components, improving accessibility for developers.

[changeset-bot]

🦋 Changeset detected

Latest commit: 40b549e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@nextui-org/theme	Patch
@nextui-org/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

@macci001 is attempting to deploy a commit to the NextUI Inc Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai]

Walkthrough

The changes in this pull request focus on enhancing the styling of the input and select components within the @nextui-org/theme package. Modifications include updates to Tailwind CSS classes for various states and variants, particularly addressing hover and focus interactions. The compoundVariants sections have been revised to improve visual consistency and feedback across input and select components. The changes aim to resolve inconsistencies noted in issue #3876 regarding the visual behavior of these components.

Changes

File Path	Change Summary
packages/core/theme/src/components/input.ts	Updated Tailwind CSS classes for input component states (flat, faded) and refined isInvalid styles.
packages/core/theme/src/components/select.ts	Modified select component styles for flat, faded, and bordered variants, enhancing hover and focus states.
.changeset/twelve-trains-smile.md	Introduced a patch for styling consistency between input and select components, linked to issue #3876.

Assessment against linked issues

Objective	Addressed	Explanation
Improve visual consistency between input and select components (3876)	✅

Possibly related PRs

• fix(theme): revise input isInvalid styles #3010: This PR revises the isInvalid styles in the input component, which is directly related to the changes made in the main PR that also focuses on enhancing the visual feedback for invalid inputs.
• fix(theme): fixing the label placement in select and input #3869: This PR addresses label placement in the input and select components, which is relevant as the main PR modifies the input component's visual states and could be affected by label positioning.
• fix(theme): fullWidth in input and select #3768: This PR fixes the fullWidth functionality in both input and select components, which relates to the main PR's focus on the input component's styling and behavior.
• fix(theme): apply tw nested group #3909: This PR applies nested group features to improve styling in components, including select, which is relevant as the main PR modifies the input component's styling and could be impacted by similar styling adjustments.

Suggested labels

👀 Status: In Review

Suggested reviewers

• wingkwong
• jrgarciadev

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 52c9042 and 40b549e.

📒 Files selected for processing (3)

• .changeset/twelve-trains-smile.md (1 hunks)
• packages/core/theme/src/components/input.ts (7 hunks)
• packages/core/theme/src/components/select.ts (2 hunks)

✅ Files skipped from review due to trivial changes (1)

• .changeset/twelve-trains-smile.md

🚧 Files skipped from review as they are similar to previous changes (2)

• packages/core/theme/src/components/input.ts
• packages/core/theme/src/components/select.ts

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 4

🧹 Outside diff range and nitpick comments (2)

.changeset/twelve-trains-smile.md (1)

1-5: LGTM! Consider a minor improvement to the change description.

The changeset file correctly identifies the package being updated and provides a concise description of the change. This aligns well with the PR objectives and the issue it addresses.

Consider slightly expanding the change description for improved clarity. Here's a suggested revision:

-Making faded variant select's background styling on hover consistent with the input(#3876)
+Making faded variant select's background styling on hover consistent with the input component (Fixes #3876)

This minor change explicitly mentions that it's being made consistent with the "input component" and clarifies that it fixes the referenced issue.

packages/core/theme/src/components/select.ts (1)

Inconsistent Hover State Styling Across Components

The current changes in select.ts introduce hover state styling that differs from the input components:

1. Select Component (select.ts):

   • Uses data-[hover=true]:bg-default-50 for the flat variant.
   • Other variants also show varied approaches to hover state styling.

2. Input Component (input.ts & date-input.ts):

   • Utilizes hover:bg-primary-100 and data-[hover=true]:border-primary consistently across color variants.

These differences can lead to a fragmented user experience. To align the hover state styling of the select component with the input components:

• Update Hover Styles:

  • Use background and border properties similar to the input component (e.g., hover:bg-primary-100).

• Review Color Variants:

  • Ensure all color variants in the select component follow the input component's hover state patterns.

• Consistency Check:

  • Verify that hover states across all related components behave uniformly to maintain a cohesive design system.

Implementing these changes will enhance consistency and improve the overall user interface coherence.

🔗 Analysis chain

Line range hint 1-624: Overall assessment: Inconsistencies in hover state styling

After reviewing the changes in this file, I've noticed several inconsistencies in the hover state styling across different color variants of the flat variant:

1. The default flat variant now uses a lighter color on hover (bg-default-50).
2. The compound variants for default, primary, secondary, success, and warning colors all use darker colors on hover (bg-*-200).

These inconsistencies don't align with the PR objective of making the faded variant select's background styling on hover consistent with the input component. To address this:

1. Review the intended behavior for the hover states across all color variants.
2. Ensure that the changes are consistent with the input component's behavior.
3. Apply uniform changes across all color variants to maintain consistency.
4. Consider reverting the changes that introduce darker hover states if they don't align with the intended behavior.

Please revisit these changes to ensure they meet the PR's objectives and maintain consistency across the component.

To verify the input component's behavior for comparison, you can run the following script:

This will help ensure that the select component's hover state styling is consistent with the input component.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for the input component's hover state styling
rg --type typescript 'input.*hover' packages/core/theme/src/components/

Length of output: 108

---

Script:

#!/bin/bash
# Search for the input component's hover state styling in TypeScript files
rg --glob "*.ts" --glob "*.tsx" 'input.*hover' packages/core/theme/src/components/

Length of output: 2166

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 8f62613 and ffe8174.

📒 Files selected for processing (2)

• .changeset/twelve-trains-smile.md (1 hunks)
• packages/core/theme/src/components/select.ts (6 hunks)

🧰 Additional context used

🔇 Additional comments (1)

packages/core/theme/src/components/select.ts (1)

41-41: Hover state adjustment aligns with PR objective

The change from bg-default-200 to bg-default-50 for the hover state makes the background lighter on hover. This modification aligns well with the PR objective of making the faded variant select's background styling consistent with the input component.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nextui-docs-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 16, 2024 0:05am
nextui-storybook-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 16, 2024 0:05am

[wingkwong]

Except the default one, all other colors look different compared with those in input. Currently the pr changes make the contrast lower in dark mode. You may compare Colors section in Select and Input.

[jrgarciadev]

Hey @macci001 thanks for this contribution, let's do the opposite, let's make the input look like the select styles -- the select hover colors look better

[macci001]

@jrgarciadev sure, will do!

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

packages/core/theme/src/components/input.ts (1)

Line range hint 265-334: LGTM! Consistent color variant styling.

The changes establish a uniform pattern across all color variants:

• Base: {color}-100
• Hover/Focus: {color}-50

This creates a consistent and predictable user experience.

Consider extracting the common pattern into a reusable utility function to reduce repetition:

const getColorVariant = (color: string) => ({
  inputWrapper: [
    `bg-${color}-100`,
    `data-[hover=true]:bg-${color}-50`,
    `text-${color}`,
    `group-data-[focus=true]:bg-${color}-50`,
    `placeholder:text-${color}`,
  ]
});

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 883b388 and 52c9042.

📒 Files selected for processing (3)

• .changeset/few-jars-flow.md (1 hunks)
• packages/core/theme/src/components/input.ts (7 hunks)
• packages/core/theme/src/components/select.ts (2 hunks)

✅ Files skipped from review due to trivial changes (1)

• .changeset/few-jars-flow.md

🧰 Additional context used

📓 Learnings (1)

packages/core/theme/src/components/select.ts (2)

Learnt from: macci001
PR: nextui-org/nextui#3881
File: packages/core/theme/src/components/select.ts:227-231
Timestamp: 2024-10-13T09:36:58.967Z
Learning: In `packages/core/theme/src/components/select.ts`, changes may sometimes be formatting-only. Ensure to verify whether changes are only formatting-related before flagging potential issues.

Learnt from: macci001
PR: nextui-org/nextui#3881
File: packages/core/theme/src/components/select.ts:255-255
Timestamp: 2024-10-13T09:37:50.957Z
Learning: When updating the hover state for the faded variant of the select component, changing the background from `bg-secondary-50` to `bg-secondary-200` aligns with making the styling consistent with the input component.

🔇 Additional comments (4)

packages/core/theme/src/components/select.ts (3)

41-42: LGTM: Consistent hover and focus states

The changes appropriately align the hover and focus states to use the same background color, improving visual consistency.

---

50-50: LGTM: Unified interactive states

The consolidation of hover, focus, and open states with consistent border colors improves code maintainability while ensuring visual consistency.

---

306-307: LGTM: Consistent color variant styling

The changes maintain a consistent pattern across all color variants, properly consolidating the interactive states while preserving color-specific borders.

Also applies to: 315-316, 324-325, 333-334, 342-343

packages/core/theme/src/components/input.ts (1)

Line range hint 78-87: LGTM! Enhanced hover and focus states.

The changes improve visual feedback by:

• Using a lighter background color on hover for the flat variant
• Adding border color feedback for focus state in the faded variant

[macci001]

• Made the changes to make input similar to select in case of flat variant.
• Updated the example in PR description.

[jrgarciadev]

Thank you! @macci001