Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NxTransformations matrix order #603

Conversation

matthew-d-jones
Copy link
Member

If a transformation depends on another, the one it depends on should be applied first and should therefore be further to the right in the expression for T_f. Therefore, in the NxTransformation documentation this does not look correct to me:

For a chain of three transformations, where T_1 depends on T_2 and that in turn depends on T_3, the final transformation T_f is
T_f = T_3 T_2 T_1

Please check I have not misunderstood the existing documentation before merging!

@PeterC-DLS
Copy link
Contributor

PeterC-DLS commented Dec 7, 2017

The depends_on chain is physical not mathematical. So the ordering is different for passive transformations.

@prjemian
Copy link
Contributor

prjemian commented Dec 7, 2017

@PeterC-DLS: Can you supply a few words to clarify so others are not also unclear?

@PeterC-DLS
Copy link
Contributor

The difference between active and passive transformations are the former moves things in a fixed coordinate frame whereas the latter is changing between coordinate frames.

To interpret information from, for example, a detector (say a pixel location), we are transforming from the detector's frame via each positioner to the laboratory frame fixed to the last positioner that depends on ".".

@matthew-d-jones
Copy link
Member Author

matthew-d-jones commented Dec 8, 2017

@PeterC-DLS Thank you, makes sense. I will create a new PR for just the equation rendering fixes.
It is explained quite clearly on the design page actually, perhaps I can link to that from the class definition.

@matthew-d-jones
Copy link
Member Author

Created #604 for the rendering fixes.

@matthew-d-jones matthew-d-jones deleted the fix_transformation_matrix_order branch December 8, 2017 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants