Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering of mathematical expressions for transformations #604

Conversation

matthew-d-jones
Copy link
Member

@matthew-d-jones matthew-d-jones commented Dec 8, 2017

Rendering of mathematical expressions for transformations in the NxTransformations class definition is broken, see http://download.nexusformat.org/sphinx/classes/base_classes/NXtransformations.html
There seems to be a problem with multiline math blocks, these changes work around the problem by reducing them to a single line.

Before fix:
before_fix

After fix:
after_fix

@prjemian prjemian self-assigned this Jan 17, 2018
@prjemian prjemian self-requested a review January 17, 2018 04:10
@prjemian
Copy link
Contributor

I approve this. Built the docs locally, viewed the NXtransformations page. Looks good. Thanks.

@prjemian prjemian merged commit 7f9ad32 into nexusformat:master Jan 17, 2018
@prjemian prjemian added this to the NXDL 2018.1 milestone Jan 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants