Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev > main: first release #1

Merged
merged 35 commits into from
Mar 21, 2024
Merged

Dev > main: first release #1

merged 35 commits into from
Mar 21, 2024

Conversation

matthdsm
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nf-test test main.nf.test -profile test,docker).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@matthdsm matthdsm requested review from tomiles and nvnieuwk March 11, 2024 07:29
nvnieuwk
nvnieuwk reviewed Mar 11, 2024
View reviewed changes
Copy link
Member

@nvnieuwk nvnieuwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments: I'll approve if the tests pass :)

workflows/sampletracking.nf Show resolved Hide resolved
nextflow_schema.json Outdated Show resolved Hide resolved
assets/schema_input.json Outdated Show resolved Hide resolved
@matthdsm
Copy link
Member Author

nvnieuwk
nvnieuwk reviewed Mar 21, 2024
View reviewed changes
Copy link
Member

@nvnieuwk nvnieuwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more comments

assets/samplesheet.csv Outdated Show resolved Hide resolved
tests/workflows/sampletracking.nf.test.snap Outdated Show resolved Hide resolved
nvnieuwk
nvnieuwk approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@nvnieuwk nvnieuwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@matthdsm matthdsm merged commit 68a8b27 into main Mar 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvnieuwk nvnieuwk nvnieuwk approved these changes

@tomiles tomiles Awaiting requested review from tomiles

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthdsm @nvnieuwk