Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spaces to satisfy nf-core download for singularity #126

Merged
merged 4 commits into from
May 2, 2023
Merged

Add spaces to satisfy nf-core download for singularity #126

merged 4 commits into from
May 2, 2023

Conversation

pinin4fjords
Copy link
Member

@pinin4fjords pinin4fjords commented May 1, 2023 •
edited
Loading

Itty bitty one to add spaces to un-break nf-core download with this workflow.

I also smuggled in a line to add an explicit profile for rnaseq for consistency with docs (though defaults correspond to rnaseq anyway).

Closes #122

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/differentialabundance branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented May 1, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit 0032fef

+| ✅ 160 tests passed       |+

✅ Tests passed:

Run details

  • nf-core/tools version 2.8
  • Run at 2023-05-02 09:44:33

@pinin4fjords pinin4fjords requested a review from SPPearce May 1, 2023 16:57
pinin4fjords
pinin4fjords commented May 1, 2023
View reviewed changes
nextflow.config
@@ -306,6 +306,7 @@ profiles {
test_nogtf { includeConfig 'conf/test_nogtf.config' }
test_full { includeConfig 'conf/test_full.config' }
affy { includeConfig 'conf/affy.config' }
rnaseq { includeConfig 'conf/rnaseq.config' }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just adding for consistency with docs.

@pinin4fjords
Copy link
Member Author

Thanks @WackerO !

@pinin4fjords pinin4fjords merged commit 07543be into nf-core:dev May 2, 2023
@pinin4fjords pinin4fjords deleted the fix_singularity_download2 branch May 2, 2023 10:13
@pinin4fjords pinin4fjords added this to the 1.3.0 milestone May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WackerO WackerO WackerO approved these changes

@SPPearce SPPearce Awaiting requested review from SPPearce

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pinin4fjords @WackerO