-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nf-test #366
Add nf-test #366
Conversation
|
Thank you @jfy133 !! Now lets get this done 💯 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just having a quick look - @jasmezz is there a reason why you're having indpeendent snapshots for every single file?
Why not snapshot (file1, file2, file3).match
etc? If not all in one snapshot, you could at least group by tool?
Yes, good question: I tried to do so, but the syntax from modules does not work on pipeline level for some reason. If you like it more compact, I will check how other pipelines do it. |
Also, they are grouped by tool at the moment. 🧐 |
I mean one Check createtaxdb for s pipeline example |
… nf-test-conversion
… nf-test-conversion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert some minor changes which will be addressed in a separate PR
I'm confused? Why not merge dev into this PR (by the looks of it) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor comments. Most of them I realise now stem from the suboptimal samplesheet_reduced
dataset, but I guess testing files that don't produce output is valid otherwise?
That said the preannotated samplesheet includes non-annotated stuff, and these look OK :)
Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
Replaces classic workflow with nf-tests (third attempt)
PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).