Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Important! Template update for nf-core/tools v2.11 #327

Merged
merged 5 commits into from
Jan 24, 2024
Merged

Important! Template update for nf-core/tools v2.11 #327

merged 5 commits into from
Jan 24, 2024

Conversation

nf-core-bot
Copy link
Member

Version 2.11 of nf-core/tools has just been released with updates to the nf-core template. This automated pull-request attempts to apply the relevant updates to this pipeline.

Please make sure to merge this pull-request as soon as possible, resolving any merge conflicts in the nf-core-template-merge-2.11 branch (or your own fork, if you prefer). Once complete, make a new minor release of your pipeline.

For instructions on how to merge this PR, please see https://nf-co.re/docs/contributing/sync/.

For more information about this release of nf-core/tools, please see the v2.11 release page.

@jfy133 jfy133 self-assigned this Jan 24, 2024
@jfy133 jfy133 requested a review from a team January 24, 2024 08:37
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 24, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit a17732c

+| ✅ 163 tests passed       |+
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

✅ Tests passed:

Run details

  • nf-core/tools version 2.11.1
  • Run at 2024-01-24 10:35:25

jasmezz
jasmezz approved these changes Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@jasmezz jasmezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me just fix the deeparg-only workflow (which shouldn't be there).

conf/modules.config Show resolved Hide resolved
@jfy133
Copy link
Member

jfy133 commented Jan 24, 2024

@nf-core-bot fix linting

Darcy220606
Darcy220606 approved these changes Jan 24, 2024
View reviewed changes
modules/nf-core/fastqc/tests/main.nf.test
)
}
}
// TODO
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you still need this comment part here ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's from template, we can ignore

@jfy133 jfy133 merged commit 72372b6 into dev Jan 24, 2024
16 checks passed
@jfy133 jfy133 deleted the nf-core-template-merge-2.11 branch January 24, 2024 12:32
@jasmezz jasmezz mentioned this pull request Jul 29, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfy133 jfy133 jfy133 left review comments

@Darcy220606 Darcy220606 Darcy220606 approved these changes

@jasmezz jasmezz jasmezz approved these changes

Assignees

@jfy133 jfy133

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nf-core-bot @jfy133 @jasmezz @Darcy220606