Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new module: scscplit #5071

Open
1 of 4 tasks
Tracked by #48
Zethson opened this issue Mar 7, 2024 · 4 comments
Open
1 of 4 tasks
Tracked by #48

new module: scscplit #5071

Zethson opened this issue Mar 7, 2024 · 4 comments
Assignees
Labels
new module Adding a new module

Comments

@Zethson
Copy link
Member

Zethson commented Mar 7, 2024

Is there an existing module for this?

  • I have searched for the existing module

Is there an open PR for this?

  • I have searched for existing PRs

Is there an open issue for this?

  • I have searched for existing issues

Are you going to work on this?

  • If I'm planning to work on this module, I added myself to the Assignees to facilitate tracking who is working on the module

Tasks

Preview Give feedback
  1. 1 of 2
    new module
    IreneRobles
@Zethson Zethson added the new module Adding a new module label Mar 7, 2024
@IreneRobles
Copy link

I am not sure whether I will have time to finish this during the hackathon. However, a bioarpipeline that has an scsplit module, which I am going to use as a template.

https://github.com/theislab/hadge/blob/main/modules/multi/gene_demulti/scsplit.nf

@wxicu
Copy link
Contributor

wxicu commented Mar 20, 2024

@IreneRobles hi, you are totally right. The goal is to convert the scsplit module of hadge to nf-core. Please feel free to ask if you have any problems.

@IreneRobles
Copy link

IreneRobles commented Mar 20, 2024

Hi @wxicu! Cool! I am almost there. Technically, the scsplit tool should have three tools: genotype, count and run. I am almost there with scsplit/count.

For reference (in case I do not have time to finish this):

I got the module running and passing tests, what is left is to finish my branch of nf-test-datasets, PR it and link my module tests to that branch. I managed to get a nice docker running scsplit with some help from Simon Murray (dockerfile in my nf-modules repo).

I have drafter a PR here: #5349

@wxicu
Copy link
Contributor

wxicu commented Mar 23, 2024

Hi @IreneRobles
cool! I have also added a small dataset for hadge modules to nf-core(https://github.com/nf-core/test-datasets/tree/modules/data/genomics/homo_sapiens/demultiplexing). You can also use this one for testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new module Adding a new module
Projects
No open projects
Status: No status
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants