Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New module: scsplit/count #5349

Open
wants to merge 52 commits into
base: master
Choose a base branch
from
Open

Conversation

IreneRobles
Copy link

@IreneRobles IreneRobles commented Mar 20, 2024

Summary of changes

New module scsplit/count to demultiplex single-cell data.

PR checklist

Closes #5348

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements. --> neither docker or conda biocontainer work for scsplit
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda

@IreneRobles IreneRobles marked this pull request as ready for review April 23, 2024 15:04
@IreneRobles IreneRobles requested a review from a team as a code owner April 23, 2024 15:04
@IreneRobles IreneRobles requested review from vagkaratzas and removed request for a team April 23, 2024 15:04
@IreneRobles IreneRobles self-assigned this Apr 23, 2024
@IreneRobles IreneRobles requested a review from wxicu April 23, 2024 15:05
@Zethson Zethson requested a review from mari-ga April 23, 2024 15:13
Copy link
Contributor

@wxicu wxicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing this module. I have left my suggestion to solve the error when running in a conda environemnt, hope this will work!

modules/nf-core/scsplit/count/main.nf Outdated Show resolved Hide resolved
@SPPearce
Copy link
Contributor

SPPearce commented May 8, 2024

Ideally the scsplit tool is put into bioconda, which would make the docker and singularity containers automatically. That would mean that scsplit would be present in the $PATH in all three container engines.
If you need help putting scsplit into bioconda, there is a bioconda channel on the nf-core slack.

@wxicu
Copy link
Contributor

wxicu commented May 9, 2024

uld make the docker and singularity containers automatically. That would mean that scsplit would be present in the $PATH in all three container engines.
If you need help putting scsplit into bioconda, there is a bioconda channel on the nf-core slack.

scsplit is already available on bioconda(https://anaconda.org/bioconda/scsplit) but idk why it is still not present in $PATH

@SPPearce
Copy link
Contributor

SPPearce commented May 9, 2024

uld make the docker and singularity containers automatically. That would mean that scsplit would be present in the $PATH in all three container engines.
If you need help putting scsplit into bioconda, there is a bioconda channel on the nf-core slack.

scsplit is already available on bioconda(https://anaconda.org/bioconda/scsplit) but idk why it is still not present in $PATH

Well, this PR is currently not using bioconda or the associated biocontainer, so maybe if it is swapped to those it'll work fine?

@wxicu
Copy link
Contributor

wxicu commented May 9, 2024

uld make the docker and singularity containers automatically. That would mean that scsplit would be present in the $PATH in all three container engines.
If you need help putting scsplit into bioconda, there is a bioconda channel on the nf-core slack.

scsplit is already available on bioconda(https://anaconda.org/bioconda/scsplit) but idk why it is still not present in $PATH

Well, this PR is currently not using bioconda or the associated biocontainer, so maybe if it is swapped to those it'll work fine?

nope scSplit is still not found in $PATH..

@wxicu
Copy link
Contributor

wxicu commented May 12, 2024

Gernal update:

  • I modified the dockerfile because another two functions of scsplit doesnt support newer version of packages like numpy. etc I downgraded to python3.9.
  • to make scsplit work in conda, I have opened a PR to add an entry point in the conda package. I tried to provide a solution to call scsplit with command line in conda env before this is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

new module: scsplit/count module
3 participants