Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new module: Busco #1605

Closed
wants to merge 10 commits into from
Closed

new module: Busco #1605

wants to merge 10 commits into from

Conversation

jvhagey
Copy link
Contributor

@jvhagey jvhagey commented May 3, 2022

Closes #1603

  • This comment contains a description of changes (with reason).
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

@jvhagey jvhagey added new module Adding a new module WIP Work in progress labels May 3, 2022
@jvhagey jvhagey self-assigned this May 3, 2022
@sateeshperi
Copy link
Contributor

sateeshperi commented May 4, 2022

recommend closing this in favor of #1239 @jvhagey

@jvhagey jvhagey closed this May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new module Adding a new module WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants