Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove icdiff in favour of pdiff in gitpod image #4686

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

mahesh-panchal
Copy link
Member

Removes installation of icdiff in favour of using pdiff installed in the nf-core Gitpod image (nf-core/tools#2642).

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

@mahesh-panchal
Copy link
Member Author

I'll wait for Sateesh to approve too just in case.

Copy link
Contributor

@sateeshperi sateeshperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sateeshperi sateeshperi added this pull request to the merge queue Jan 8, 2024
Merged via the queue into nf-core:master with commit 5d571ee Jan 8, 2024
9 checks passed
@mahesh-panchal mahesh-panchal deleted the update_gitpod_yml branch January 9, 2024 10:29
lrauschning pushed a commit to lrauschning/modules that referenced this pull request Jan 17, 2024
lrauschning pushed a commit to lrauschning/modules that referenced this pull request Jan 17, 2024
jennylsmith pushed a commit to RSC-RP/modules that referenced this pull request Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants