add checkProfileProvided to utils_nfcore_pipeline #4891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirpedrol
requested review from
koenbossers,
mashehu,
adamrtalbot and
drpatelh
and removed request for
a team
mashehu
approved these changes
Feb 9, 2024
| @@ -21,6 +21,26 @@ nextflow_function { | |||
| } | |||
| } | |||
|
|
|||
| test("Test Function checkProfileProvided") { | |||
There was a problem hiding this comment.
How about a test with a faulty input?
There was a problem hiding this comment.
I couldn't find a way to provide a workflow.profile in the nf-test docs, nor how to check the content of the warning logging, so I'm not sure how to test a case of failure in this case.
There was a problem hiding this comment.
Okay, maybe I am thinking too much in a pytest way. 🙂 Good as it is then
jch-13
pushed a commit
to jch-13/modules
that referenced
this pull request
Mar 19, 2024
jennylsmith
pushed a commit
to RSC-RP/modules
that referenced
this pull request
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
checkProfileProvidedtoutils_nfcore_pipelineaccording to the changes in the pipeline template nf-core/tools#2736