Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new module for Toulligqc #5131
Added new module for Toulligqc #5131
Changes from 19 commits
54d98e9
f8b0e5e
d2f56a1
06bab25
85f8598
c09b0a8
fc83273
1b07601
d3e6d86
8f78d86
4310cd3
f8e3db5
67eaf13
f891afb
f2bc6d1
939aa63
2190de6
486a54c
4557e5d
c5f24db
8680dc5
9bbc2b7
2281f51
efdd607
d61ddd9
c64f776
47eb172
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add one test with all three if they are not mutually exclusive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can do but I will need to upload new data to the nf-core/tets-datasets repo as I don't think the sequencing summary, FASTQ and BAM files come from the same run..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok, that would be a bit awkward... maybe you could do a local test and otherwise I avert my eyes ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay thank you! I'll do a local test this afternoon and will let you know the outcome :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have done a test with a sequencing summary and fastq file and it worked!
I don't have access to a bam file right now but there is no reason for it not to work :)