Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new module: crabz #5351

Merged
merged 14 commits into from
Mar 28, 2024
Merged

new module: crabz #5351

merged 14 commits into from
Mar 28, 2024

Conversation

camlloyd
Copy link
Contributor

@camlloyd camlloyd commented Mar 20, 2024 •
edited
Loading

PR checklist

Closes #5258

  • Added new module crabz
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@camlloyd camlloyd self-assigned this Mar 20, 2024
@camlloyd camlloyd requested a review from a team as a code owner March 20, 2024 17:39
@camlloyd camlloyd requested review from vagkaratzas and removed request for a team March 20, 2024 17:39
famosab
famosab reviewed Mar 21, 2024
View reviewed changes
Copy link
Contributor

@famosab famosab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good already :) I added some minor suggestions.

Looking at the error from the CI test it seems to me that there might be a small syntax somewhere but I did not find it yet.

modules/nf-core/crabz/compress/main.nf Outdated Show resolved Hide resolved
modules/nf-core/crabz/compress/tests/main.nf.test Outdated Show resolved Hide resolved
modules/nf-core/crabz/compress/tests/main.nf.test Outdated Show resolved Hide resolved
modules/nf-core/crabz/decompress/tests/main.nf.test Outdated Show resolved Hide resolved
modules/nf-core/crabz/decompress/tests/main.nf.test Outdated Show resolved Hide resolved
modules/nf-core/crabz/compress/environment.yml Show resolved Hide resolved
modules/nf-core/crabz/compress/meta.yml Outdated Show resolved Hide resolved
modules/nf-core/crabz/compress/tests/main.nf.test Show resolved Hide resolved
modules/nf-core/crabz/decompress/meta.yml Outdated Show resolved Hide resolved
famosab
famosab approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@famosab famosab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@camlloyd camlloyd enabled auto-merge March 28, 2024 09:33
@camlloyd camlloyd added this pull request to the merge queue Mar 28, 2024
Merged via the queue into nf-core:master with commit 0494c99 Mar 28, 2024
15 checks passed
@camlloyd camlloyd deleted the crabz branch March 28, 2024 09:47
jvfe added a commit that referenced this pull request Mar 28, 2024
@jvfe
Merge branch 'master' into nf-test_phispy
2d824ce 
* master:
  Added new module for Toulligqc (#5131)
  Make `mosdepth` stub use `gzip` for `.gz` files (#5410)
  Update hmmsearch to 3.4 (#5408)
  port `controlfreec-makegraph` to nf-test (#5393)
  port `controlfreec-freec` to nf-test (#5398)
  port `controlfreec-assesssignificance` to nf-test (#5396)
  port `controlfreec-makegraph2` to nf-test (#5392)
  new module: crabz (#5351)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@famosab famosab famosab approved these changes

@vagkaratzas vagkaratzas Awaiting requested review from vagkaratzas vagkaratzas was automatically assigned from nf-core/nf-test

Assignees

@camlloyd camlloyd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

new module: crabz
2 participants
@camlloyd @famosab