Skip to content

Conversation

@LouisLeNezet
Copy link
Contributor

@LouisLeNezet LouisLeNezet commented Jul 23, 2024

This PR introduce a new subworkflow that downsample alignment files to a given depth.

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@LouisLeNezet LouisLeNezet marked this pull request as ready for review July 23, 2024 08:00
@LouisLeNezet LouisLeNezet requested review from a team and louperelo and removed request for a team July 23, 2024 08:00
Copy link
Contributor

@fellen31 fellen31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really understand how this would be downsampling the reads in SAMTOOLS_VIEW, have you missed something?

LouisLeNezet and others added 6 commits July 23, 2024 14:52
Co-authored-by: Felix Lenner <52530259+fellen31@users.noreply.github.com>
Co-authored-by: Felix Lenner <52530259+fellen31@users.noreply.github.com>
Co-authored-by: Felix Lenner <52530259+fellen31@users.noreply.github.com>
Co-authored-by: Felix Lenner <52530259+fellen31@users.noreply.github.com>
@LouisLeNezet
Copy link
Contributor Author

Hi @fellen31 I've effectively forgot to push my modification of SAMTOOLS_VIEW.

@LouisLeNezet LouisLeNezet requested a review from fellen31 July 23, 2024 14:00
LouisLeNezet and others added 2 commits July 23, 2024 17:44
Co-authored-by: Felix Lenner <52530259+fellen31@users.noreply.github.com>
…nfig

Co-authored-by: Felix Lenner <52530259+fellen31@users.noreply.github.com>
@LouisLeNezet LouisLeNezet requested a review from fellen31 July 23, 2024 16:22
Copy link
Contributor

@SPPearce SPPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but I'm not sure on the name.
This is downsampling to a mean depth, rather than a total number of reads, which would be another valid option on how to downsample.

LouisLeNezet and others added 2 commits July 24, 2024 11:06
Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com>
@LouisLeNezet LouisLeNezet changed the title New sbwf bam_downsample_samtools New sbwf bam_subsampledepth_samtools Jul 24, 2024
@LouisLeNezet LouisLeNezet requested a review from SPPearce July 24, 2024 10:03
Copy link
Contributor

@fellen31 fellen31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks a lot better to me, nice! Will let @SPPearce or someone else approve the naming though :)

@LouisLeNezet LouisLeNezet requested a review from SPPearce July 29, 2024 09:24
@SPPearce
Copy link
Contributor

Looks good to me, name approved on the subworkflows channel in the slack.

@SPPearce
Copy link
Contributor

@LouisLeNezet , I think we're good to merge this in if you are happy.

@LouisLeNezet LouisLeNezet added this pull request to the merge queue Aug 23, 2024
Merged via the queue into nf-core:master with commit 5c32697 Aug 23, 2024
@LouisLeNezet LouisLeNezet deleted the bam_downsample_samtools branch August 23, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants