-
Notifications
You must be signed in to change notification settings - Fork 955
New sbwf bam_subsampledepth_samtools #6019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New sbwf bam_subsampledepth_samtools #6019
Conversation
fellen31
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really understand how this would be downsampling the reads in SAMTOOLS_VIEW, have you missed something?
subworkflows/nf-core/bam_downsample_samtools/tests/main.nf.test
Outdated
Show resolved
Hide resolved
subworkflows/nf-core/bam_downsample_samtools/tests/main.nf.test
Outdated
Show resolved
Hide resolved
Co-authored-by: Felix Lenner <52530259+fellen31@users.noreply.github.com>
Co-authored-by: Felix Lenner <52530259+fellen31@users.noreply.github.com>
Co-authored-by: Felix Lenner <52530259+fellen31@users.noreply.github.com>
Co-authored-by: Felix Lenner <52530259+fellen31@users.noreply.github.com>
…ules into bam_downsample_samtools
|
Hi @fellen31 I've effectively forgot to push my modification of |
subworkflows/nf-core/bam_downsample_samtools/tests/nextflow.config
Outdated
Show resolved
Hide resolved
Co-authored-by: Felix Lenner <52530259+fellen31@users.noreply.github.com>
…nfig Co-authored-by: Felix Lenner <52530259+fellen31@users.noreply.github.com>
Co-authored-by: Felix Lenner <52530259+fellen31@users.noreply.github.com>
SPPearce
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, but I'm not sure on the name.
This is downsampling to a mean depth, rather than a total number of reads, which would be another valid option on how to downsample.
Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com>
fellen31
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks a lot better to me, nice! Will let @SPPearce or someone else approve the naming though :)
|
Looks good to me, name approved on the subworkflows channel in the slack. |
|
@LouisLeNezet , I think we're good to merge this in if you are happy. |
This PR introduce a new subworkflow that downsample alignment files to a given depth.
versions.ymlfile.labelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda