Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump GUNC and add gunc/run test #6920

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from
Draft

Conversation

dialvarezs
Copy link
Contributor

@dialvarezs dialvarezs commented Nov 1, 2024

This PR includes:

  • Version bump in all GUNC modules
  • A modification in the gunc/run module to accept multiple input files
  • Add tests for gunc/run and gunc/mergecheckm

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@dialvarezs dialvarezs requested a review from a team as a code owner November 1, 2024 06:47
@dialvarezs dialvarezs marked this pull request as draft November 1, 2024 06:57
@dialvarezs dialvarezs marked this pull request as ready for review November 1, 2024 08:35
@dialvarezs dialvarezs mentioned this pull request Nov 1, 2024
11 tasks
@jfy133
Copy link
Member

jfy133 commented Nov 5, 2024

@dialvarezs this looks good but the module updates need to come via PRs into https://github.com/nf-core/modules and added to the pipline with nf-core modules update <module>/<subcommand>

@jfy133 jfy133 marked this pull request as draft November 5, 2024 11:57
@dialvarezs
Copy link
Contributor Author

@jfy133 I don't get what you mean exactly. This is nf-core/modules, or am I doing something wrong?

@jfy133
Copy link
Member

jfy133 commented Nov 11, 2024

I mixed up my PRs, sorry @dialvarezs ! You're all good here once snapshots updated 😅 (thoguht this was the mag PR...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants