Minor refactor on attachMultiqcReport function. #7129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The attachMultiqcReport function was renamed as the function does not attach the multiqc report, but rather simply tests if the input object contains zero, one, or more multiqc reports. The function was also refactored to be more resilient to the type of object passed as input. The function can now not only take a collection of zero, one, or more more multiqc reports, but will also handle the case if the input object is a Path object.
robsyme
force-pushed
the
more-resilient-multiqc-attchments
branch
from
2532aaa to
e4c07f3
Compare
maxulysse
approved these changes
Nov 30, 2024
|
Feel free to merge |
mirpedrol
approved these changes
Dec 3, 2024
|
Some of the tests are failing complaining about the |
4 tasks
LouisLeNezet
pushed a commit
to LouisLeNezet/modules
that referenced
this pull request
Dec 4, 2024
* Minor refactor on attachMultiqcReport function. The attachMultiqcReport function was renamed as the function does not attach the multiqc report, but rather simply tests if the input object contains zero, one, or more multiqc reports. The function was also refactored to be more resilient to the type of object passed as input. The function can now not only take a collection of zero, one, or more more multiqc reports, but will also handle the case if the input object is a Path object. * fix switch brackets --------- Co-authored-by: Júlia Mir Pedrol <mirp.julia@gmail.com>
|
The VSCode plugin is complaining about the switch: |
|
Great point Simon. Fixed with #7168 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The attachMultiqcReport function was renamed as the function does not attach the multiqc report, but rather simply tests if the input object contains zero, one, or more multiqc reports and returns a single report if available and, issues a warning in the zero or >1 case.
The function was also refactored to be more resilient to the type of object passed as input. The function can now not only take a collection of zero, one, or more more multiqc reports, but will also handle the case if the input object is a Path object. Handling a path might be useful just in case somebody uses this workflow and calls .first() instead of .toList() to convert the queue channel into a value channel.
PR checklist
versions.ymlfile.labelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda