-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ampcombi 2.0.1 #7142
Merged
Darcy220606
merged 18 commits into
nf-core:master
from
Darcy220606:update_ampcombi2.0.1
Dec 11, 2024
Merged
Update ampcombi 2.0.1 #7142
Darcy220606
merged 18 commits into
nf-core:master
from
Darcy220606:update_ampcombi2.0.1
Dec 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
jfy133
reviewed
Dec 4, 2024
jfy133
reviewed
Dec 5, 2024
@Darcy220606 said to wait because need to add a missing optional input for INterProScan |
@jfy133 all done now ✨ 👽 ✨ |
jfy133
approved these changes
Dec 11, 2024
jfy133
reviewed
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor corrections then I think good to go
jfy133
approved these changes
Dec 11, 2024
Merge away @Darcy220606 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
This PR updates ampcombi2 from 0.2.2 to 2.0.1, which also fixes the issues encountered in nf-core/funcscan
versions.yml
file.label
nf-core modules test <MODULE> --profile docker
nf-core modules test <MODULE> --profile singularity
nf-core modules test <MODULE> --profile conda
nf-core subworkflows test <SUBWORKFLOW> --profile docker
nf-core subworkflows test <SUBWORKFLOW> --profile singularity
nf-core subworkflows test <SUBWORKFLOW> --profile conda