Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added basicpy nftest #7228

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

added basicpy nftest #7228

wants to merge 4 commits into from

Conversation

kbestak
Copy link
Contributor

@kbestak kbestak commented Dec 16, 2024

PR checklist

Closes #6927
Decided it would be easier to open a new PR than resolve conflicts (#6929)
Migrating basicpy to nf-test. Works with Docker and Singularity

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda

@kbestak kbestak requested a review from a team as a code owner December 16, 2024 11:54
@kbestak kbestak mentioned this pull request Dec 16, 2024
17 tasks
@kbestak
Copy link
Contributor Author

kbestak commented Dec 16, 2024

How come the conda tests are running? I added the module to the conda_skip.yml.

Additionally, running both docker and singularity within Gitpod worked reproducibly and I don't fully understand why it is failing here, could it be a specification needed for the new CI that I missed?

@SPPearce
Copy link
Contributor

How come the conda tests are running? I added the module to the conda_skip.yml.

Additionally, running both docker and singularity within Gitpod worked reproducibly and I don't fully understand why it is failing here, could it be a specification needed for the new CI that I missed?

I'll take a look at why conda is running.
The docker and singularity are failing because the md5sum is different, not related to the CI. Maybe there is a hidden timestamp inside the file?

@kbestak
Copy link
Contributor Author

kbestak commented Dec 19, 2024

Is there a reason why the docker and singularity outputs are different compared to the snapshot? In Gitpod, the same md5sum is created everytime, I'll still test locally. Is there a way to access the output files from the CI to check for differences?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nf-test for Basicpy
2 participants