Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD CATPACK_DOWNLOAD #7253

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

ADD CATPACK_DOWNLOAD #7253

wants to merge 5 commits into from

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Dec 19, 2024

A real test is not possible because they download >10GBs databases (NCBI Nr or GTDB)

closes #5586

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@jfy133 jfy133 marked this pull request as ready for review December 19, 2024 14:01
Copy link
Contributor

@jasmezz jasmezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You want a review already, right? (Not sure because wrong channel)
Snapshots not passing yet 👀

modules/nf-core/catpack/download/meta.yml Outdated Show resolved Hide resolved
modules/nf-core/catpack/download/meta.yml Outdated Show resolved Hide resolved
modules/nf-core/catpack/download/tests/main.nf.test Outdated Show resolved Hide resolved
@jfy133 jfy133 mentioned this pull request Dec 19, 2024
22 tasks
@@ -42,7 +42,7 @@ output:
description: CSV table with rows as reference genomes, columns samples and entries as log2 PTR
pattern: "*.csv"
ontologies:
- edam: "http://edamontology.org/format_3752"
- edam: "http://edamontology.org/data_3752"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- edam: "http://edamontology.org/data_3752"
- edam: "http://edamontology.org/format_3752"

I think you want format here; with data the link would be broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new module: CATPACK_DOWNLOAD
2 participants