Skip to content

Conversation

famosab
Copy link
Contributor

@famosab famosab commented Oct 1, 2025

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@famosab
Copy link
Contributor Author

famosab commented Oct 1, 2025

(Even though I think this newer version is only important for #8837)

@famosab famosab requested a review from matthdsm October 1, 2025 08:37
@famosab
Copy link
Contributor Author

famosab commented Oct 1, 2025

@matthdsm added the new version here :D I don't think there is a need to update in sarek though

@famosab famosab enabled auto-merge October 1, 2025 08:41
@famosab famosab added this pull request to the merge queue Oct 1, 2025
Merged via the queue into nf-core:master with commit 78cc4e9 Oct 1, 2025
39 checks passed
@famosab famosab deleted the vcu branch October 1, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants