Skip to content

Update test files for Glimpse #9467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
LouisLeNezet merged 16 commits into from
Dec 4, 2025
Merged

Update test files for Glimpse #9467

LouisLeNezet merged 16 commits into from
Dec 4, 2025

Conversation

@LouisLeNezet
Copy link
Contributor

@LouisLeNezet LouisLeNezet commented Nov 26, 2025

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@LouisLeNezet LouisLeNezet marked this pull request as ready for review November 26, 2025 20:38
@LouisLeNezet LouisLeNezet self-assigned this Nov 26, 2025
mashehu
mashehu reviewed Nov 27, 2025
View reviewed changes
mashehu
mashehu reviewed Nov 27, 2025
View reviewed changes
@LouisLeNezet LouisLeNezet requested a review from mashehu November 27, 2025 10:20
@LouisLeNezet LouisLeNezet mentioned this pull request Dec 4, 2025
Merged
17 tasks
@LouisLeNezet LouisLeNezet added this pull request to the merge queue Dec 4, 2025
Merged via the queue into nf-core:master with commit d911d93 Dec 4, 2025
68 of 71 checks passed
@LouisLeNezet LouisLeNezet deleted the upd_glimpse branch December 4, 2025 15:05
LouisLeNezet added a commit to LouisLeNezet/modules that referenced this pull request Dec 4, 2025
@LouisLeNezet @mashehu
Update test files for Glimpse (nf-core#9467)
f738955 
* Update glimpse

* Update chunk

* Update concordance

* Revert changes

* Fix glimpse test

* Fix glimpse

* Fix glimpse2 tests

* Update sbwf

* Remove old snapshots

* Update glimpse

* Update modules/nf-core/glimpse2/concordance/tests/main.nf.test

Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>

* Update test

---------

Co-authored-by: LouisLeNezet <louislenezet@gmaio.com>
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
vagkaratzas pushed a commit that referenced this pull request Dec 8, 2025
@LouisLeNezet @mashehu @vagkaratzas
Update test files for Glimpse (#9467)
19b67c4 
* Update glimpse

* Update chunk

* Update concordance

* Revert changes

* Fix glimpse test

* Fix glimpse

* Fix glimpse2 tests

* Update sbwf

* Remove old snapshots

* Update glimpse

* Update modules/nf-core/glimpse2/concordance/tests/main.nf.test

Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>

* Update test

---------

Co-authored-by: LouisLeNezet <louislenezet@gmaio.com>
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mashehu mashehu mashehu approved these changes

Assignees

@LouisLeNezet LouisLeNezet

Labels

Ready for Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LouisLeNezet @mashehu