Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate entries from probands and upd_children in meta #420

Merged
merged 3 commits into from
Sep 4, 2023
Merged

Remove duplicate entries from probands and upd_children in meta #420

merged 3 commits into from
Sep 4, 2023

Conversation

ramprasadn
Copy link
Collaborator

PR checklist

This PR addressed issue #418

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/raredisease branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Ensure the test suite passes (nextflow run . -profile test_one_sample,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@ramprasadn ramprasadn changed the title Issue418 Remove duplicate entries from probands and upd_children in meta. Sep 4, 2023
@ramprasadn ramprasadn changed the title Remove duplicate entries from probands and upd_children in meta. Remove duplicate entries from probands and upd_children in meta Sep 4, 2023
@ramprasadn ramprasadn marked this pull request as ready for review September 4, 2023 07:15
@github-actions
Copy link

github-actions bot commented Sep 4, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 3241886

+| ✅ 151 tests passed       |+
#| ❔   4 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required

❔ Tests ignored:

  • files_exist - File is ignored: conf/modules.config
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore or pyproject.toml

✅ Tests passed:

Run details

  • nf-core/tools version 2.9
  • Run at 2023-09-04 07:20:36

asp8200
asp8200 approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@asp8200 asp8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ramprasadn ramprasadn merged commit ce52552 into nf-core:dev Sep 4, 2023
@ramprasadn ramprasadn mentioned this pull request Sep 4, 2023
Closed
@jemten jemten deleted the issue418 branch September 5, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asp8200 asp8200 asp8200 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ramprasadn @asp8200