Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty lines in samplesheet.csv cause a crash #759

Closed
holmrenser opened this issue Feb 4, 2022 · 1 comment
Closed

Empty lines in samplesheet.csv cause a crash #759

holmrenser opened this issue Feb 4, 2022 · 1 comment
Labels
enhancement WIP Work in progress
Milestone

Comments

@holmrenser
Copy link

Description of the bug

Empty lines in samplesheet.csv (for example having a trailing newline) cause the workflow to crash. I think this seems a bit overly strict and can easily be parsed?

Command used and terminal output

No response

Relevant files

No response

System information

No response

@holmrenser holmrenser added the bug Something isn't working label Feb 4, 2022
@drpatelh drpatelh added this to the 3.6 milestone Feb 7, 2022
@drpatelh drpatelh added enhancement and removed bug Something isn't working labels Feb 7, 2022
drpatelh added a commit to drpatelh/nf-core-rnaseq that referenced this issue Feb 20, 2022
@drpatelh drpatelh added the WIP Work in progress label Feb 20, 2022
@drpatelh
Copy link
Member

Thanks for reporting @holmrenser ! Fixed in drpatelh@71c0d38

There can be a blank line anywhere in the file now and it will be ignored. I think it's reasonable to be stricter with this sort of validation as in theory these lines have no information content. Surprised it has taken this long for someone to report it though! 🙂

Now that we have a samplesheet schema, the hope is that we will be able to use this to validate the contents at some point We made a start in #633 but the validation may be less flexible if we decide to use standard libs. Lets see what happens.

Take care!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement WIP Work in progress
Projects
None yet
Development

No branches or pull requests

2 participants