Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix CI pipeline AGAIN #1262

Merged
merged 5 commits into from
Mar 13, 2024
Merged

Try to fix CI pipeline AGAIN #1262

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1795f8e
Try to fix CI pipeline AGAIN
adamrtalbot Mar 12, 2024
dcec9db
Check for empty list
adamrtalbot Mar 12, 2024
8789e4f
Revert needs statement
adamrtalbot Mar 12, 2024
21c23e2
Trying something else...
adamrtalbot Mar 12, 2024
0df628a
Add everything to test dep
adamrtalbot Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,6 @@ jobs:
# Mostly, we define additional 'pipeline' or 'all' tests here
files_yaml: |
".":
- .github/workflows/**
- nf-test.config
- nextflow.config
tests:
Expand Down Expand Up @@ -183,7 +182,7 @@ jobs:
test:
name: ${{ matrix.tags }} ${{ matrix.profile }} NF-${{ matrix.NXF_VER }}
needs: [nf-test-changes]
if: needs.nf-test-changes.outputs.changes
if: needs.nf-test-changes.outputs.tags != '[]'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bit was the problem, the job wasn't being skipped it was a matrix of 1.

runs-on: ubuntu-latest
strategy:
fail-fast: false
Expand Down Expand Up @@ -251,12 +250,11 @@ jobs:

confirm-pass:
runs-on: ubuntu-latest
# needs: [test, star_salmon, star_rsem, hisat2, pseudo]
needs: [test]
needs: [test, star_salmon, star_rsem, hisat2, pseudo]
if: always()
steps:
- name: All tests ok
if: ${{ success() }}
if: ${{ !contains(needs.*.result, 'failure') }}
run: exit 0
- name: One or more tests failed
if: ${{ contains(needs.*.result, 'failure') }}
Expand All @@ -265,5 +263,6 @@ jobs:
- name: debug-print
if: always()
run: |
echo ${{ needs.nf-test-changes.outputs.changes }}
echo "toJSON(needs) = ${{ toJSON(needs) }}"
echo "toJSON(needs.*.result) = ${{ toJSON(needs.*.result) }}"
Loading