Fix tests & lint #394
Merged
Fix tests & lint #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Salmon used to fail because of an outdated index in the test_gzipped test. Needs to be merged into the nf-core/test-datasets eventually.
apeltzer
approved these changes
Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#382 didn't fix all tests and lints. This PR is to address these problems.
Requires updating the gzipped STAR index. See nf-core/test-datasets#124.
Currently I link to my branch of
test-datasetsto make the tests pass, once the nf-core/test-datasets#124 is merged, I can change that.PR checklist
devrather thanmasternextflow run . -profile test,docker).nf-core lint .).Documentation indocsis updatedCHANGELOG.mdis updatedREADME.mdis updatedLearn more about contributing: https://github.com/nf-core/rnaseq/tree/master/.github/CONTRIBUTING.md