Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix (231): Null object accessed in multiqc channel #239

Merged
merged 3 commits into from
Jun 13, 2023
Merged

fix (231): Null object accessed in multiqc channel #239

merged 3 commits into from
Jun 13, 2023

Conversation

adamrtalbot
Copy link
Contributor

  • Fix issue with multiqc channel trying to access null objects
  • add explicit channel values to handle multiqc inputs

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/scrnaseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@adamrtalbot adamrtalbot requested a review from robsyme June 13, 2023 09:29
@github-actions
Copy link

github-actions bot commented Jun 13, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit e6ca31c

+| ✅ 157 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: '2.3.2'
  • system_exit - System.exit in WorkflowScrnaseq.groovy: System.exit(1) [line 18]

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.8
  • Run at 2023-06-13 09:30:38

robsyme
robsyme approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@robsyme robsyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Are there any lingering instances of this problem in scrnaseq?

@adamrtalbot
Copy link
Contributor Author

I've checked with test_full on tower and it looks good!

@adamrtalbot adamrtalbot merged commit d745a82 into nf-core:dev Jun 13, 2023
@adamrtalbot adamrtalbot mentioned this pull request Jun 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robsyme robsyme robsyme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamrtalbot @robsyme